update machine api providers to use proper golang version #18348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates all the machine api providers to use the proper go versions depending on the openshift release. It is being made to address issues with `go vet` that arising due to an old golang version (1.13). For all the providers the following changes have been made: * master, 4.8, and 4.9 now use go lang 1.16 as the base image * 4.7 now uses go lang 1.15 as the base image
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Member
|
/approve Some on-going flakes with metal ipi, but the ones that passed looked good and nothing failed in an unexpected way. |
Contributor
|
@elmiko: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/assign @Gal-Zaidman |
Member
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
/approve |
Contributor
openshift-ci
bot
added
the
approved
Contributor
|
@elmiko: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates all the machine api providers to use the proper go
versions depending on the openshift release. It is being made to address
issues with
go vetthat arising due to an old golang version (1.13).For all the providers the following changes have been made:
This change is needed by:
openshift/cluster-api-provider-kubevirt#35
openshift/cluster-api-provider-openstack#180
openshift/cluster-api-provider-baremetal#151
openshift/cluster-api-provider-ovirt#103
Given the size of this change, I would like to get sign off from the following teams